Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default GitLab API endpoint to v4 #298

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Change default GitLab API endpoint to v4 #298

merged 2 commits into from
Jun 12, 2018

Conversation

micjabbour
Copy link
Contributor

Fixes #297

@micjabbour micjabbour changed the title Change default API endpoint to v4 Change default GitLab API endpoint to v4 Jun 8, 2018
@micjabbour
Copy link
Contributor Author

micjabbour commented Jun 8, 2018 •
edited
Loading

I am still not sure about endpoint paths in these tests since they already point to non-existent domains, but I added another commit to update them for consistency nevertheless

@doomspork doomspork requested review from mmozuras and a team June 12, 2018 21:29
@doomspork doomspork merged commit e895004 into prontolabs:master Jun 12, 2018
@remz99 remz99 mentioned this pull request Nov 17, 2018
Closed
apiology pushed a commit to apiology/pronto that referenced this pull request Dec 27, 2019
@micjabbour @doomspork
Change default GitLab API endpoint to v4 (prontolabs#298)
f3cf287 
* Change default GitLab API endpoint to v4

Fixes prontolabs#297

* Update GitLab API endpoints in RSpec tests to v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doomspork doomspork doomspork approved these changes

@mmozuras mmozuras Awaiting requested review from mmozuras

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micjabbour @doomspork