Adds GitLab formatter #50
Conversation
| @@ -54,6 +54,42 @@ formatter = Pronto::Formatter::GithubFormatter.new # or GithubPullRequestFormatt | |||
| Pronto.run('origin/master', '.', formatter) | |||
| ``` | |||
|
|
|||
| ### GitLab Integration | |||
There was a problem hiding this comment.
Could you split changes to the README to a separate pull request? I'll merge it in after releasing a new version. Otherwise, it could get a little confusing with people asking "why doesn't it work if it's in README?" 😄
|
Please add an entry to the CHANGELOG. |
| @@ -0,0 +1,29 @@ | |||
| module Pronto | |||
| module Formatter | |||
| class GitlabFormatter | |||
There was a problem hiding this comment.
There's some duplication between Github/Gitlab formatters/clients. But I can figure out if I want to refactor that in any way myself, don't worry about it 😄
jeroenj
force-pushed
the
gitlab-formatter
branch
from
0c6d064
to
80ad2f3
Compare
|
Ok, cleaned up everything. :) |
|
@jeroenj looks good, thanks! 😄 |
|
Just a reminder that this code won't work as long as there isn't a new gitlab gem released. It will work if you set up pronto using bundled and use the master branch for the gitlab gem. I'll make a PR with the dependency changes as soon as it is released. |
|
@jeroenj 👍 |
Closes #25
We've been running this in production for the past few months and it has been working smoothly.
This will be released with GitLat v7.5.0 tomorrow. This does wait on an update on NARKOZ/gitlab#88 so it can not be merged just yet.
Could you review the code and let me know if anything should be changed?