Gitlab integration: comments are duplicated because of default 20-item pagination #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeroenj could you take a look? |
|
Nice find. 500 seems like a sensible default. I'd accept it. :) |
|
Just a random number from the top of my head ;-) |
|
@siebertm could you add an entry to CHANGELOG? |
siebertm
force-pushed
the
fix-gitlab-comment-duplication
branch
from
beadcf5
to
9df5367
Compare
This leads to duplicate comments. The ideal way would be to paginate through all comments (with link headers), but the Gitlab gem doesn't allow this currently.
siebertm
force-pushed
the
fix-gitlab-comment-duplication
branch
from
9df5367
to
c09bbdf
Compare
mmozuras
added a commit
that referenced
this pull request
Jan 29, 2015
Gitlab integration: comments are duplicated because of default 20-item pagination
|
Released with this fix as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a small issue which leads to duplicate comments on when using the GitlabFormatter: When you have more than 20 comments on a commit, pagination kicks in and not all comments are seen, thus duplicate checking breaks.
I just set per_page to 500 to quickly work around that issue.