Possible fix for issue with Github PR formatter commenting on wrong lines #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@11mdlow sorry for taking so long to answer. Doing it the proposed way wouldn't work when there are multiple lines that are exactly same, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, this is to follow up to my previous pr: #72 and is an attempt to fix #39.
The issue is still the same: pronto has issues where you make commits/changes around the same sections of code, as it will actually pick up a line from it's last context, and not when it was added. This then calculates an incorrect position, and comments on a wrong line.
I'll admit this isn't be ideal behavior, as it will now comment on an outdated diff, but to me it is better than commenting on the wrong line.
What do you think?