More robust sync for unusual check-in states #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robknight
force-pushed
the
rob/sync-fixes
branch
2 times, most recently
from
9aaadee to
dff3fae
Compare
robknight
commented
Sep 26, 2023
| step( | ||
| "should not be able to check in with a ticket that has already been used to check in", | ||
| async function () { | ||
| // TODO |
There was a problem hiding this comment.
This test exists further up the file, so this can be removed.
robknight
force-pushed
the
rob/sync-fixes
branch
from
dff3fae to
318948d
Compare
ichub
approved these changes
Sep 26, 2023
| return true; | ||
| } | ||
| } | ||
| else { |
There was a problem hiding this comment.
i don't think you've run the autoformatter on this file
There was a problem hiding this comment.
prettier seems to be broken for me in VSCode. I'll see if I can figure out what's wrong with it.
There was a problem hiding this comment.
sometimes it's necessary to restart vscode to fix that. super annoying. #718
| @@ -635,6 +642,87 @@ describe("devconnect functionality", function () { | |||
| ); | |||
| }); | |||
|
|
|||
| /** | |||
| * This covers the case where we have a ticket marked as consumed, but | |||
| * the check-in is cancelled in Pretix. | |||
There was a problem hiding this comment.
'check-in is cancelled' is kind of confusing terminology - do you mean that it is 'effectively cancelled out by a check-in exit entry' or that a 'check-in entry was cancelled' or that a 'check-in entry was deleted altogether'?
robknight
force-pushed
the
rob/sync-fixes
branch
from
318948d to
a9825e5
Compare
robknight
force-pushed
the
rob/sync-fixes
branch
from
a9825e5 to
12f0200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694
Fixes #693