Improve content panel location system #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use pane uuids everywhere, instead of the old addresses of the form `windowNum:paneId`. * This is used for the widget group control mapping * This is used in ContentManager for updating content anywhere (i.e. in any window)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use UUID4's to identify content panels in a way that is unique across windows,
and across reloads. This replaces the existing system of windowNumber:DijitPaneId,
which was brittle, and required careful maintenance every time a panel was moved.
RELEASE NOTES
Bug Fixes
Widget group control mappings across windows used to be able to create an
inconsistent state after the primary window was reloaded. Now such mappings
are properly saved and restored.