Skip to content

Improve handling of multi-modal node labels #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

skieffer
Copy link
Member

Nodes can define both latex and docref labels. The behavior we want is as follows:

  • if both docref and latex are provided, we want the latter to
    make the label, and the former only to navigate a linked doc

  • if only a docref is provided, we want it to provide both navigation,
    and the label

However, at present the "both" case is incorrect, in that the label is showing
a combination of the latex and docref rendered labels.

RELEASE NOTES

Improvements

  • When nodes define both latex and docref labels, the latter now only serves
    to navigate a linked doc; it contributes to the label only when no latex
    label is defined.

When both a docref and a latex label are defined, use the docref
only for navigation; do not add it to the label.
@skieffer skieffer merged commit 4ffff1f into proofscape:main Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant