Repair static dir in OCA image #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built-in `css` and `img` dirs in `pise/server` were being incorrectly put under a version dir. The URL has a version number in it, for cache busting, but, internally, Flask routes these requests to a filesystem path that does not include the version segment. Due to the incorrect placement, our 404 page was failing to find the img and css it needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in
cssandimgdirs inpise/serverwere being incorrectly put under a version dir. The URL has a version number in it, for cache busting, but, internally, Flask routes these requests to a filesystem path that does not include the version segment.Due to the incorrect placement, our 404 page was failing to find the img and css it needed.