Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency handling: changes and improvements #76

Merged
merged 18 commits into from
Jun 3, 2024

Conversation

skieffer
Copy link
Member

@skieffer skieffer commented Jun 3, 2024

Improvements

  • Support automatically building repo dependencies (recursively) in PISE.
  • Improve build process:
    • Report missing dependencies earlier.
    • Roll back build outputs and graph db indexing, upon failed build.
  • Add startup check for sync between build output and graph db, to
    automatically clean up any excess build output before starting.

Breaking

  • Rename root module fields:
    • dependencies --> deps
    • change_log --> changeLog

skieffer added 18 commits June 2, 2024 16:09

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
dependencies --> deps
change_log --> changeLog

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
When operating the OCA, do not show the warning message.
Set a max width.
Do not require sync on builds @wip.
Now pivoting on the startup sync check. Instead of complaining and refusing to
start up, now we're just cleaning up the excess build output programmatically,
and starting up.
We improve the build process in a couple of ways:

* Proactively check for missing dependencies during the early build steps, instead
  of waiting to discover missing deps when resolving imports. This changes behavior
  visible to users, in that just declaring a dependency will result in a build error if that
  dep is missing (whereas before there was no error until you tried to import).

* If building or indexing fails and raises a `PfscExcep`, we try to clean up
  all build outputs and indexing, except for cache outputs.
When the raised `PfscExcep` defines `extra_data()`, this will be written into
the error response under the new `err_info` field.
Now, when you ask to open a repo through the textbox in the library sidebar,
you will get prompts to automatically clone and/or build missing dependencies,
recursively.
Extend auto-deps support to builds triggered from:
* Ctrl-B or context menu in editor
* Context menu on tree items
* Do not list again deps that have already been ok'ed.
* Provide a dismissal checkbox.
@skieffer skieffer added enhancement New feature or request breaking Includes breaking changes requiring a major version increment labels Jun 3, 2024
@skieffer skieffer merged commit 4057f1f into proofscape:main Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Includes breaking changes requiring a major version increment enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant