-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency handling: changes and improvements #76
Merged
+651
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependencies --> deps change_log --> changeLog
When operating the OCA, do not show the warning message.
Set a max width.
Do not require sync on builds @wip.
Now pivoting on the startup sync check. Instead of complaining and refusing to start up, now we're just cleaning up the excess build output programmatically, and starting up.
We improve the build process in a couple of ways: * Proactively check for missing dependencies during the early build steps, instead of waiting to discover missing deps when resolving imports. This changes behavior visible to users, in that just declaring a dependency will result in a build error if that dep is missing (whereas before there was no error until you tried to import). * If building or indexing fails and raises a `PfscExcep`, we try to clean up all build outputs and indexing, except for cache outputs.
When the raised `PfscExcep` defines `extra_data()`, this will be written into the error response under the new `err_info` field.
Now, when you ask to open a repo through the textbox in the library sidebar, you will get prompts to automatically clone and/or build missing dependencies, recursively.
Extend auto-deps support to builds triggered from: * Ctrl-B or context menu in editor * Context menu on tree items
* Do not list again deps that have already been ok'ed. * Provide a dismissal checkbox.
skieffer
added
enhancement
New feature or request
breaking
Includes breaking changes requiring a major version increment
labels
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Includes breaking changes requiring a major version increment
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
automatically clean up any excess build output before starting.
Breaking
dependencies
-->deps
change_log
-->changeLog