QueryBus with FinalizeGuard enabled returns null

[lezhnev74]

Hi, I am lost with FinalizeGuard and how to set it up properly. I am not sure if this relates to Laravel package or to MessageBus core.

1. I have my query and corresponding finder. On success it resolves Deferred like this:

class QueryFinder {
    function __invoke($query, Deferred $deferred = null): void
    {
        //...
        $deferred->resolve($query_result);
    }
}

2. I enabled FinalizeGuard in prooph.php config file.

3. But the result of the query returns null.

// I use facade
$query_result = QueryBus::resultFrom($query);
// $query_result is null now

4. If I disable the FinalizeGuard then query returns valid result. So it led me into looking inside of the FinalizeGuard code.

5. Looking at 48 line: https://github.com/prooph/service-bus/blob/c239acfd43cf8eec577e30ce0aa7da86d87b6191/src/Plugin/Guard/FinalizeGuard.php#L48
   It creates a new Promise and here it losts resolved result.

It seems that I misuse QueryBus. Can you suggest the right way of resolving Deferred object inside my QueryFinder which works with FinalizeGuard?

[basz]

It seems that I misuse QueryBus

Why you think you misuse the query bus?

$this->queryBus
            ->dispatch(
                (new GetCustomer(['customer_id' => ...]))
            )
            ->done(function (QueryResult $result) use (&$dto) {
                $dto = $result->data();
            });

This works for me with FinalizeGuard enabled

[lezhnev74]

Hmm, can you show how you resolve deferred promise inside the finder class?

[basz]

    public function getCustomer(GetCustomer $query, Deferred $deferred): void
    {
        /** @var Customer $customer */
        if ($customer = $this->entityManager->getRepository(Customer::class)->find($query->customerId())) {
            $customerDTO = CustomerDTO::fromEntity($customer, $query->included());

            $deferred->resolve(JsonApiQueryResult::with($customerDTO, [], new EncodingParameters($query->included())));
        } else {
            $deferred->reject(new DomainException('Not found', 404));
        }
    }

[lezhnev74]

I have removed everything and included just bare message bus and implemented this test:
https://github.com/lezhnev74/prooph-query-test/blob/prooph-bare/tests/QueryTest.php

It has 3 tests:

• executing query with no guards [pass]
• executing query with RouteGuard [pass]
• executing query with FinalizeGuard [fail]

Hmm, why does it fail in the last test?

[lezhnev74]

This is not about Laravel packag I'd say, so I am closing this issue.
The issue in message bus hub: prooph/service-bus#177