Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid array_merge due to appending #164

Merged
merged 2 commits into from
Jul 2, 2017

Conversation

basz
Copy link
Member

@basz basz commented Jul 2, 2017

ServiceLocator does not correctly merge new listeners to list of known listeners

https://3v4l.org/ZbsuF

array_merge will" "If, however, the arrays contain numeric keys, the later value will not overwrite the original value, but will be appended"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.138% when pulling 7d3ff05 on basz:fix-listener-appending into 9c58750 on prooph:master.

Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case that fails without this fix.

@basz
Copy link
Member Author

basz commented Jul 2, 2017

can I get access to the ActionEvent $actionEvent from the test?

@basz
Copy link
Member Author

basz commented Jul 2, 2017

@prolic there...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.138% when pulling c4f4bff on basz:fix-listener-appending into 9c58750 on prooph:master.

@prolic prolic merged commit 2f8a9a7 into prooph:master Jul 2, 2017
@prolic prolic self-assigned this Jul 2, 2017
@prolic prolic added the bug label Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants