Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FinalizeGuard #178

Merged
merged 2 commits into from
Dec 26, 2017
Merged

fix FinalizeGuard #178

merged 2 commits into from
Dec 26, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Dec 26, 2017

resolves #177

@prolic prolic added the bug label Dec 26, 2017
@prolic
Copy link
Member Author

prolic commented Dec 26, 2017

/cc @lezhnev74 @basz

basz
basz reviewed Dec 26, 2017
View reviewed changes
Copy link
Member

@basz basz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good

@lezhnev74
Copy link

Cool! Looks good to me:

  • now the result is passed through the chain
  • a test passes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9c1f69d on finalize_guard into c239acf on master.

@prolic prolic merged commit fd83b41 into master Dec 26, 2017
@prolic prolic deleted the finalize_guard branch December 26, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basz basz basz left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryBus returns null with FinalizeGuard plugin included
4 participants
@prolic @lezhnev74 @coveralls @basz