Feature/string message initializer plugin #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
docs are covered with #83 |
|
@bweston92 good job, thx |
codeliner
added a commit
that referenced
this pull request
Oct 20, 2015
…zer-plugin Feature/string message initializer plugin
| use Prooph\Common\Event\DetachAggregateHandlers; | ||
| use Prooph\ServiceBus\MessageBus; | ||
|
|
||
| final class StringMessageInitializerPlugin implements ActionEventListenerAggregate |
There was a problem hiding this comment.
i am not sure if we wan't to have a plugin for this. This behaviour should be part of the service bus by default. Thoughts @codeliner ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
When a message is dispatched and is a string the message contents will be set the to the message name so the router doesn't receive "string" as the dispatched message.
Any background context you want to provide?
I was using strings to represent query commands instead of making query classes. How-ever by default the router uses "get_type" on the dispatched message, this makes the router look for "string" how-ever I need to to be the original sting value I dispatched when the router asks for message name.
Definition of Done: