Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of size #108

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Fix use of size #108

merged 1 commit into from
Dec 8, 2016

Conversation

jopasserat
Copy link
Member

I think it's important enough to be merged in master without waiting for a new release bringing features from next.

What do you think @alkino ?

I'll make a static RC build with this fix available as a release in proot-static-build

@alkino
Copy link

alkino commented Nov 22, 2016

Maybe we can do a 5.1.1 with this one and the other one for seccomp.

@jopasserat
Copy link
Member Author

Yep this one is definitely worth a 5.1.1
(I'm finalising the Docker to build the static binaries at the moment)

As for seccomp we don't really have a proper fix yet.
Typically it stills crashes for CARE when re-executed with seccomp (due to the change of user id and kernel version).

Do you think we should release a non-Seccomp version?
I'm fine with it, but I don't know what to expect from a performance point of view.

@alkino
Copy link

alkino commented Dec 7, 2016

As previously said, I don't know seccomp at all. So...

@jopasserat jopasserat merged commit f2839cf into master Dec 8, 2016
@jopasserat jopasserat deleted the hotfixLoader branch September 17, 2017 15:24
@dawnsky2006
Copy link

Running Ubuntu apt without ROOT gives an error: root@localhost:/root# neofetch
proot warning: unknown syscall 278

@oxr463
Copy link
Collaborator

oxr463 commented Jun 10, 2020

@Flytreels please open a new issue

@62f
Copy link

62f commented Aug 5, 2020

Which version of Ubuntu? What is the output of dmesg? Keep in mind the ‘hotfix’ will keep modern kernels from running, and proot binary has only been compiled for x86_64.

@dawnsky2006
Copy link

This problem is fixed in the new version,sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants