Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rootless containers #204

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SvenDowideit
Copy link

I'm trying out some things with rootless namespace vs no-namespace container usage, and wonder if @AkihiroSuda 's fork is necessary, or if these changes can be merged

:)

I've basically naively rebased - so feel free to tell me off.

jorge-lip and others added 5 commits January 7, 2020 17:11
This commit allows preserving file owner information as
`user.rootlesscontainers` xattr values.
Please refer to https://rootlesscontaine.rs/ for further information.

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
… build on fedora.

Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda
Copy link

thanks

@AkihiroSuda
Copy link

I think rootless-containers#2 needs to be fixed

@AkihiroSuda
Copy link

also needs rootless-containers@2a2a37e

@@ -10,7 +10,7 @@ Buildroot : %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
Prefix : /usr
Name : proot

BuildRequires: libtalloc-devel
BuildRequires: libtalloc-devel, protobuf-c-devel, libattr-devel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be declared as optional dependencies. Not sure off the top of my head how to do that with RPM.

@@ -0,0 +1,18 @@
FROM debian:9 AS build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,6 +1,8 @@
# If you want to build outside of the source tree, use the -f option:
# make -f ${SOMEWHERE}/proot/src/GNUmakefile

PERSISTENT_CHOWN := 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be disabled by default.


CARE_LDFLAGS = -larchive
CARE_LDFLAGS = -larchive -static
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be static by default.

@@ -0,0 +1,202 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and all other accompanying files should be moved under src/extention/.

@@ -0,0 +1,13 @@
# rootlesscontainers.proto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rewritten to use reStructuredText.

@@ -0,0 +1,103 @@
/* Generated by the protocol buffer compiler. DO NOT EDIT! */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated files should not be included in the repository, (See: #198).

@@ -0,0 +1,86 @@
/* Generated by the protocol buffer compiler. DO NOT EDIT! */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous.

@@ -20,6 +20,7 @@
* 02110-1301 USA.
*/

#include <stdio.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all from #130, isn't it?

@brad-hue
Copy link

brad-hue commented Apr 7, 2020

Thanks

@oxr463 oxr463 added this to the PRoot Next milestone Aug 29, 2021
@oxr463 oxr463 removed this from the PRoot Next milestone Oct 1, 2021
@oxr463 oxr463 changed the title Rootlesscontainers from https://github.com/rootless-containers/PRoot Support for rootless containers Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants