-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for rootless containers #204
base: master
Are you sure you want to change the base?
Conversation
This commit allows preserving file owner information as `user.rootlesscontainers` xattr values. Please refer to https://rootlesscontaine.rs/ for further information. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
… build on fedora. Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
thanks |
I think rootless-containers#2 needs to be fixed |
also needs rootless-containers@2a2a37e |
…iners/runrootless Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@@ -10,7 +10,7 @@ Buildroot : %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) | |||
Prefix : /usr | |||
Name : proot | |||
|
|||
BuildRequires: libtalloc-devel | |||
BuildRequires: libtalloc-devel, protobuf-c-devel, libattr-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be declared as optional dependencies. Not sure off the top of my head how to do that with RPM.
@@ -0,0 +1,18 @@ | |||
FROM debian:9 AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Dockerfile structure, https://github.com/proot-me/proot/tree/test-docker
@@ -1,6 +1,8 @@ | |||
# If you want to build outside of the source tree, use the -f option: | |||
# make -f ${SOMEWHERE}/proot/src/GNUmakefile | |||
|
|||
PERSISTENT_CHOWN := 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be disabled by default.
|
||
CARE_LDFLAGS = -larchive | ||
CARE_LDFLAGS = -larchive -static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be static
by default.
@@ -0,0 +1,202 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and all other accompanying files should be moved under src/extention/
.
@@ -0,0 +1,13 @@ | |||
# rootlesscontainers.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be rewritten to use reStructuredText.
@@ -0,0 +1,103 @@ | |||
/* Generated by the protocol buffer compiler. DO NOT EDIT! */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-generated files should not be included in the repository, (See: #198).
@@ -0,0 +1,86 @@ | |||
/* Generated by the protocol buffer compiler. DO NOT EDIT! */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous.
@@ -20,6 +20,7 @@ | |||
* 02110-1301 USA. | |||
*/ | |||
|
|||
#include <stdio.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all from #130, isn't it?
Thanks |
I'm trying out some things with rootless namespace vs no-namespace container usage, and wonder if @AkihiroSuda 's fork is necessary, or if these changes can be merged
:)
I've basically naively rebased - so feel free to tell me off.