Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hostid #708

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Hostid #708

merged 5 commits into from
Oct 19, 2023

Conversation

forgetso
Copy link
Member

@forgetso forgetso commented Oct 19, 2023 •
edited
Loading 

(base) ➜  captcha git:(hostid) ✗ npm run hostid pronode2


hwsrv-1089745.hostwindsdns.com

dependabot bot and others added 2 commits October 19, 2023 12:12
@dependabot @forgetso
Bump rustix from 0.37.23 to 0.37.25 in /protocol (#706)
ac8e509 
Bumps [rustix](https://github.com/bytecodealliance/rustix) from 0.37.23 to 0.37.25.
- [Release notes](https://github.com/bytecodealliance/rustix/releases)
- [Commits](bytecodealliance/rustix@v0.37.23...v0.37.25)

---
updated-dependencies:
- dependency-name: rustix
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@forgetso
Command for getting node hosts
d8d9451
@pr-explainer-bot
Copy link

Pull Request Report

Changes

  1. Bumped rustix from version 0.37.23 to 0.37.25 in /protocol (#706)

Suggestions

  • Line 9 in package.json: Consider improving the readability of the hostid script by breaking it down into smaller functions or using comments to explain the logic.

Bugs

  • No bugs found.

Improvements

  • Line 9 in package.json: The hostid script could be refactored for better readability. Here's an improved version: 
    "hostid": "npm run cmd -- \"dig +short %s.prosopo.io | tail -n1 | nslookup | cut -d = -f 2 | head -n1 | cut -d ' ' -f 2 | sed 's/\\.*$//g'\""

Rating

  • Readability: 8/10
  • Performance: 9/10
  • Security: 7/10

Greetings! Here's the report for the pull request. Let me know if you need any further assistance.

HughParry
HughParry previously approved these changes Oct 19, 2023
View reviewed changes
@HughParry HughParry merged commit 04b53c3 into main Oct 19, 2023
4 checks passed
@HughParry HughParry deleted the hostid branch October 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HughParry HughParry HughParry approved these changes

@goastler goastler Awaiting requested review from goastler goastler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forgetso @HughParry