Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake8 latest version now uses pyflakes 2.0.0, and breaks prospector, #307

Closed
IDerr opened this issue Nov 29, 2018 · 3 comments
Closed

Flake8 latest version now uses pyflakes 2.0.0, and breaks prospector, #307

IDerr opened this issue Nov 29, 2018 · 3 comments

Comments

@IDerr
Copy link
Contributor

IDerr commented Nov 29, 2018

When installing prospector with flake8 latest version, you have a warning :

prospector 1.1.6.2 has requirement pyflakes<2.0.0,>=0.8.1, but you'll have pyflakes 2.0.0 which is incompatible.

Flake8 now uses pyflakes 2.0.0
https://gitlab.com/pycqa/flake8/blob/master/setup.py#L25
and is restricted by prospector
https://github.com/PyCQA/prospector/blob/8bb1970aa31b962291ef0cff4b757a34aa566298/setup.py#L29

Is it possible to be compatible with this new version?

Thanks a lot for your work
@carlio
Copy link
Contributor

carlio commented Nov 29, 2018

Pull requests always welcome!

@IDerr IDerr mentioned this issue Nov 29, 2018
Merged
@IDerr
Copy link
Contributor Author

IDerr commented Dec 3, 2018

@carlio I have opened a PR :D

@carlio carlio mentioned this issue Jun 12, 2019
Closed
@chocoelho chocoelho added this to the 1.2.0 milestone Aug 31, 2019
@ksze ksze mentioned this issue Nov 30, 2019
Closed
@chocoelho chocoelho removed this from the 1.2.0 milestone Jun 29, 2020
@chocoelho
Copy link
Contributor

Closing this issue as it is fixed in the new version of prospector to be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlio @chocoelho @IDerr