-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change restricted version of pyflakes #308
Conversation
from 2.0.0 to 2.1.0
Would it be better (and possible) to loosen the requirements to allow for minor/micro updates to Would either of these work?
|
Prospector has the problem that it is using apis of several other packages which were not really meant as libraries but rather as first-class cli tools, with their own release cycles, and some of those apis are not designed to be public but rather internal, so it's very easy for any release of any upstream dependency to break prospector. That's why things have moved to being very restrictive, because broken prospector means broken builds for lots of people and ultimately the bug reports go here first. A better "notification -> update of prospector -> release" cycle is necessary unfortunately to avoid people spending their morning working out why builds suddenly break and then prospector devs have to work out why and then it turns out that pylint renamed a function or something... |
I agree, it would be nice if only allowing micro-releases, for example, would guarantee nothing breaks and only ever fix minor bugs. But I don't think that's something you could be sure of. This is a nice new feature of github. Perhaps it can be a part of that new release cycle. Even better if say a CI job could be kicked off and tested with the new pinned version automatically. |
I've been having a similar discussion about another lib I maintain, pylint-django, as it faces the same problems: pylint-dev/pylint-django#206 |
Should give this a try. It will automatically submit PR's with updated requirements files when a dependency gets updated. |
What's the status of this? |
According to their changelog we should be good to go, I just want to give it some more trying in order to check with other repos. Checked against prospector project and it ran fine, but still need to validate this change against a wider range of projects to check if we're not going to trigger broken builds throughout repos. |
Thanks for your work guys |
Thanks @IDerr I hope to ship this soon, at least in a dev version. |
Change restricted version from 2.0.0 to 2.1.0 to fix #307