Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint fix for message definitions usage #336

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Pylint fix for message definitions usage #336

merged 2 commits into from
Jul 15, 2019

Conversation

chocoelho
Copy link
Contributor

Fix to support latest pylint message definition implementation. They're now providing the result as a list, thus the implementation similar to how they're using it internally.

c/c @carlio

@chocoelho chocoelho requested a review from carlio June 13, 2019 20:22
@coveralls
Copy link

coveralls commented Jun 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 78.006% when pulling 6f2280c on hf-pylint-messages-definition into 5a35daa on develop.

@chocoelho chocoelho changed the base branch from master to develop July 8, 2019 16:26
@chocoelho chocoelho mentioned this pull request Jul 8, 2019
Merged
@chocoelho
Copy link
Contributor Author

Rebased with develop branch

@chocoelho chocoelho merged commit f4695f5 into develop Jul 15, 2019
@chocoelho chocoelho deleted the hf-pylint-messages-definition branch July 15, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlio carlio Awaiting requested review from carlio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chocoelho @coveralls