Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#358 pycodestyle version support #359

Conversation

mattseymour
Copy link
Contributor

Bump the supported pycodestyle version from (<=2.4.0 to <=2.5.0). This aids in supporting flake8 (and other tools) which requires pycodestyle version 2.5.0.

Description

Update setup.py requirements

Related Issue

Issue #358

Motivation and Context

Without this change, it is not possible to install flake8 and prospector in the same environment without a dependency clash.

How Has This Been Tested?

  • Ran test set as well as poetry install using flake8 and prospector

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mattseymour mattseymour changed the base branch from master to develop November 26, 2019 15:29
@coveralls
Copy link

coveralls commented Nov 26, 2019

Coverage Status

Coverage decreased (-3.2%) to 71.965% when pulling 06b93ac on mattseymour:fix/issue-358-pycodestyle-version-support into 0c4fe40 on PyCQA:develop.

@chocoelho chocoelho self-requested a review December 14, 2019 16:30
Copy link
Contributor

@chocoelho chocoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattseymour

@chocoelho chocoelho merged commit d399b6e into prospector-dev:develop Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants