-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow packaging >=22.0,<23.0 #592
allow packaging >=22.0,<23.0 #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo the dependency should be >= something to be compatible with the max number of over repositories. We seems to support everything from 0 to 22.x...
Because of the dependency on |
Shouldn't we let |
Per this comment on a previous PR, it seems that the version for |
Huhuhu, right, let's listen to this guy he seems to knows what he's talking about. |
pyproject.toml
Outdated
@@ -60,7 +60,7 @@ mypy = {version = ">=0.600", optional = true} | |||
pyroma = {version = ">=2.4", optional = true} | |||
setoptconf-tmp = "^0.3.1" | |||
GitPython = "^3.1.27" | |||
packaging = "<22.0" | |||
packaging = ">=21.0,<23.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packaging = ">=21.0,<23.0" | |
packaging = "*" |
Because prospector itself does not have the constraint of its transitive dependencies. And let's not force us to open a MR each time a new packaging is out. Let's open one if packaging break something instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into fixing the requirements-detector package from which this transitive dependency comes. However I have run into downstream issues with poetry-semver and python-semver so it'll take me a little while to get a decent release of requirements-detector out.
I have just released requirements-detector version 1.1.0 which has a much more lax constraint. I'm not sure why it was set to the range it was, I forget exactly. Anyway, now it won't be an issue for prospector. |
Description
Loosen dependency on packaging from 22.0 to <23.0
Related Issue
Motivation and Context
This change will allow prospector to be installed alongside other common tools (e.g. black) use packaging >22.0.
How Has This Been Tested?
This change was tested by running the pre-commit hooks and CI workflow.
Types of changes
Checklist: