build(devcontainer): 🧑💻 add support for reproducible env #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #127 (comment)
Because a lot of this is json, this looks like a lot of lines of change. To keep this PR from growing larger, I only focused on 2 notebooks, XGBoost and pytorch. The other two can be updated to include tests, after this PR has landed.
Note: I used the same key and secret AWS uses in their example seen here
The nbmake tests are on the metadata of the cells. It's not visible in the pull request view from github unless you look at the raw json of the notebook or review the PR in vscode with the gh pull request extension.
Example of reviewing PR with github pull request vscode extension
Example of nbmake tests in notebooks
Example where of a failing test to verify nbmake was working
Test model file exists
Test model is working as expected
Test model scan gives expected results by creating json report and expecting the values
Test unsafe model report contains expected issues
Note
While writing tests for the pytorch sentiment notebook and comparing the results of the scan from the console vs the results from the json, the console showed skipped.
Should this information not also be part of the summary in the json report?
Also if you like the
Test / test-notebooks
, since it also acts as end to end tests running model scan, I'd recommend that this is also part of the required actions.