Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Build Workflow #12

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Update Build Workflow #12

merged 4 commits into from
Mar 30, 2023

Conversation

cherbel
Copy link
Member

@cherbel cherbel commented Mar 28, 2023 •
edited
Loading

  • Remove build on tag from build workflow. This is redundant and only needs to happen on push to main.
  • Adds build on pull request for extra check

@cherbel cherbel requested a review from milesjos March 28, 2023 23:09
@cherbel cherbel self-assigned this Mar 28, 2023
@cherbel cherbel marked this pull request as ready for review March 29, 2023 23:02
milesjos
milesjos approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@milesjos milesjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@cherbel cherbel merged commit 20a1514 into main Mar 30, 2023
@cherbel cherbel deleted the update-build-wf branch March 30, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesjos milesjos milesjos approved these changes

Assignees

@cherbel cherbel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherbel @milesjos