added Python test matrix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To unblock merging this, we will have to update the branch protection rules in settings and remove the old "test" CI check requirement, and add the new per-version tests instead. |
willarmiros
commented
Apr 26, 2023
CONTRIBUTING.md
Outdated
| @@ -42,6 +42,7 @@ Thanks for contributing! In order to open a PR into the NB Defense project, you' | |||
|
|
|||
| 1. Fork the repo | |||
| 2. Make your changes | |||
| 3. Optionally, follow the [pre-commit installation guide](https://pre-commit.com/#installation) to install NBDefense's pre-commit hooks. This will ensure your change passes our CI the first time. | |||
There was a problem hiding this comment.
I actually just realized that make install-dev does this automatically. Maybe instead of this we can just hint to follow the "developing with NB Defense" instructions on your local copy of your fork?
There was a problem hiding this comment.
That's a good point. Maybe we can add a step between 1 and 2 instead that says "Run make install-dev to set up your local environment."?
milesjos
previously approved these changes
Apr 26, 2023
willarmiros
force-pushed
the
test-matrix
branch
from
2704036 to
ac90ca2
Compare
willarmiros
force-pushed
the
test-matrix
branch
from
ac90ca2 to
0c2282d
Compare
milesjos
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md