Open
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
argmarco-tkd
reviewed
Feb 6, 2026
Comment on lines
+140
to
+148
| ExternalDBPAEncryptorAdapterFactory() = default; | ||
| ExternalDBPAEncryptorAdapterFactory(const ExternalDBPAEncryptorAdapterFactory&) = | ||
| delete; | ||
| ExternalDBPAEncryptorAdapterFactory& operator=( | ||
| const ExternalDBPAEncryptorAdapterFactory&) = delete; | ||
| ExternalDBPAEncryptorAdapterFactory(ExternalDBPAEncryptorAdapterFactory&&) = default; | ||
| ExternalDBPAEncryptorAdapterFactory& operator=(ExternalDBPAEncryptorAdapterFactory&&) = | ||
| default; | ||
|
|
Collaborator
There was a problem hiding this comment.
why? (again, just curiosity)
Collaborator
There was a problem hiding this comment.
(and maybe a comment is granted in the code?)
argmarco-tkd
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two remaining python github actions
ARM64 macOS 14 Python 3
Before
After
AMD64 Windows 2022 Python 3.13
Before
After
Both are now failing with an unrelated Panda test and the unrelated s3 dataset failure