Update long.js to v4 #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
Apr 19, 2019
|
Approved in April ... let's get this merged in. |
|
Is there a reason why this hasn't been merged yet? |
ci010
pushed a commit
to Voxelum/minecraft-launcher-core-node
that referenced
this pull request
Mar 27, 2020
- file-type has an async API from v13 on, more changes would be necessary to update - long can't be updated to v4 because bytebuffer depends on ~3 (protobufjs/bytebuffer.js#90)
ci010
pushed a commit
to Voxelum/minecraft-launcher-core-node
that referenced
this pull request
Apr 4, 2020
- file-type has an async API from v13 on, more changes would be necessary to update - long can't be updated to v4 because bytebuffer depends on ~3 (protobufjs/bytebuffer.js#90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates long.js to the latest major release.