-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessors usage in your implementation #373
Comments
Closing this for now. Feel free to send a pull request if this is still a requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that starting from this topic
#179
Nothing is changed with accessors, right?
The AoJ and dougrad users clearly said that current accessors implementation is just wrong and violates the ProtoBuf specification in case of setting default values for primitive fields and representing empty optional or repeated primitive fields as their defaults.
So the only motivation to use your current implementation is in not transfering the data scheme with every message, that's it.
And, at the same time, the main reason why the ProtoBuf was just created (that is the proper way of accessors usage that leads to reducing dramatically the whole data parsing time) is still ignored.
Do you plan to fix this "JS feature" somehow? Do you have any proposals how to fix it or still not? If not, I want to propose you to implement "has" accessor and to fix other accessors in the way they implemented in C++ / Java.
[UPD]:
#200 (comment)
This topic seems to me as a solution to decode message and get non-empty optional and repeated fields
The text was updated successfully, but these errors were encountered: