fix: ensure that types are always resolved #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
approved these changes
May 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that resolveAll has been optimized, go back to ensuring that it's been called on every load. This is necessary to guarantee correctness of feature helpers, not just for feature resolution. Caching should make duplicate calls extremely cheap.
Just to be safe, this also does a second round of optimizations to lookup. For a large test proto, the time to run
resolveAllhas been cut in half, in addition to the ~30x wins from the previous PR. This also increases caching a bit to reduce costs of noopresolveAllcalls, using the same namespace-based caching strategy as for feature resolution