Fix typos in asserts add LICENSE-asserts.md to package.json #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold. Sorting out the npm file list... |
We were previously just globbing the entire google/ dir, which brings in different versions of files that we don't normally publish to npm. For example, we usually publish any_pb.js, which uses commonjs requires instead of any.js, which uses closure's goog.require.
|
Ok, I think that should do it. The closure versions were getting brought into the package (I think previously I used a different target to just build the commonjs ones). It's a bit simpler/less to remember, if the package itself is explicit about what should actually go out. |
lukesandberg
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across a couple stragglers while doing a dry run of the npm release.