Skip to content

Commit

Permalink
Breaking Change: Remove deprecated reflection methods
Browse files Browse the repository at this point in the history
See https://protobuf.dev/news/2024-10-02/#reflection-methods for detail

PiperOrigin-RevId: 688656103
  • Loading branch information
anandolee authored and copybara-github committed Oct 22, 2024
1 parent 12c87c9 commit 292f964
Showing 1 changed file with 0 additions and 49 deletions.
49 changes: 0 additions & 49 deletions python/google/protobuf/reflection.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,52 +34,3 @@
GeneratedProtocolMessageType = message_factory._GENERATED_PROTOCOL_MESSAGE_TYPE

MESSAGE_CLASS_CACHE = {}


# Deprecated. Please NEVER use reflection.ParseMessage().
def ParseMessage(descriptor, byte_str):
"""Generate a new Message instance from this Descriptor and a byte string.
DEPRECATED: ParseMessage is deprecated because it is using MakeClass().
Please use MessageFactory.GetMessageClass() instead.
Args:
descriptor: Protobuf Descriptor object
byte_str: Serialized protocol buffer byte string
Returns:
Newly created protobuf Message object.
"""
warnings.warn(
'reflection.ParseMessage() is deprecated. Please use '
'MessageFactory.GetMessageClass() and message.ParseFromString() instead. '
'reflection.ParseMessage() will be removed in Jan 2025.',
stacklevel=2,
)
result_class = MakeClass(descriptor)
new_msg = result_class()
new_msg.ParseFromString(byte_str)
return new_msg


# Deprecated. Please NEVER use reflection.MakeClass().
def MakeClass(descriptor):
"""Construct a class object for a protobuf described by descriptor.
DEPRECATED: use MessageFactory.GetMessageClass() instead.
Args:
descriptor: A descriptor.Descriptor object describing the protobuf.
Returns:
The Message class object described by the descriptor.
"""
warnings.warn(
'reflection.MakeClass() is deprecated. Please use '
'MessageFactory.GetMessageClass() instead. '
'reflection.MakeClass() will be removed in Jan 2025.',
stacklevel=2,
)
# Original implementation leads to duplicate message classes, which won't play
# well with extensions. Message factory info is also missing.
# Redirect to message_factory.
return message_factory.GetMessageClass(descriptor)

0 comments on commit 292f964

Please sign in to comment.