Fix C++ ifndef_guard printer to also convert "-" to "_".

PiperOrigin-RevId: 679648401
protocolbuffers · Sep 27, 2024 · 7331b77 · 7331b77
1 parent d81e6f7
commit 7331b77
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/google/protobuf/compiler/cpp/ifndef_guard.cc b/src/google/protobuf/compiler/cpp/ifndef_guard.cc
@@ -30,6 +30,7 @@ std::string MakeIfdefGuardIdentifier(const absl::string_view header_path) {
                                                                 {
                                                                     {"/", "_"},
                                                                     {".", "_"},
+                                                                    {"-", "_"},
                                                                 })),
                       "_");
 }

diff --git a/src/google/protobuf/compiler/cpp/ifndef_guard_unittest.cc b/src/google/protobuf/compiler/cpp/ifndef_guard_unittest.cc
@@ -36,7 +36,7 @@ TEST_F(IfnDefGuardTest, Basic) {
   {
     io::Printer printer(output(), '$');
 
-    const IfdefGuardPrinter ifdef_guard(&printer, "A/B/E/alpha");
+    const IfdefGuardPrinter ifdef_guard(&printer, "A/B-E.alpha");
 
     EXPECT_FALSE(printer.failed());
   }