Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed specific MSVC settings when installing (#17285)
When installing protobuf, it creates a different directory for CMake's config files when compiling with MSVC. ![protobuf-on-windows](https://github.com/protocolbuffers/protobuf/assets/50274155/b0f5e1fa-dcb8-4c01-8118-7c6c651cda37) _gRPC build on Windows_ ![protobuf-on-linux](https://github.com/protocolbuffers/protobuf/assets/50274155/1370b476-89e7-42a0-857d-73cdcbae4f23) _gRPC build on Linux and macOS_ This is problematic because it requires conditionally setting its `protobuf_DIR` for different platforms: ```cmake if(MSVC) set(Protobuf_DIR "${PROTOBUF_PREFIX}/cmake") else() set(Protobuf_DIR "${PROTOBUF_PREFIX}/lib/cmake/protobuf") endif() ``` [The original commit that made this](7d79458) based its choice on CMake's version 3.4, which not only is deprecated but is also based on a CMake version [less than the one defined in the master file](https://github.com/protocolbuffers/protobuf/blob/main/CMakeLists.txt#L3). Since then, CMake changed its behaviour, making this distinction unnecessary. Closes #17285 COPYBARA_INTEGRATE_REVIEW=#17285 from EduMenges:main a6f2e37 PiperOrigin-RevId: 650455064
- Loading branch information