Avoid allocating iterator in TextFormat printing UnknownFieldSet

PiperOrigin-RevId: 632503842
protocolbuffers · May 10, 2024 · 8c6e5b7 · 8c6e5b7
1 parent bc80135
commit 8c6e5b7
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/java/core/src/main/java/com/google/protobuf/TextFormat.java b/java/core/src/main/java/com/google/protobuf/TextFormat.java
@@ -581,6 +581,9 @@ private void printSingleField(
 
     private static void printUnknownFields(
         final UnknownFieldSet unknownFields, final TextGenerator generator) throws IOException {
+      if (unknownFields.isEmpty()) {
+        return;
+      }
       for (Map.Entry<Integer, UnknownFieldSet.Field> entry : unknownFields.asMap().entrySet()) {
         final int number = entry.getKey();
         final UnknownFieldSet.Field field = entry.getValue();