Skip to content

Commit

Permalink
[ObjC] Collect unknown fields as data
Browse files Browse the repository at this point in the history 
Default to collecting unknown fields as data and then create the
`GPBUnknownFieldSet` on demand when requested.

This should reduce the as the extra objects are created until requested
and clears the way to eventually deprecated `GPBUnknownFieldSet` in the
future.

This also fixes the failing conformance test related to keeping the ordering.

PiperOrigin-RevId: 655929316
  • Loading branch information
@thomasvl
thomasvl committed Jul 25, 2024
1 parent bf2d4e7 commit a6b3535
Show file tree
Hide file tree
Showing 4 changed files with 405 additions and 77 deletions.
5 changes: 0 additions & 5 deletions conformance/failure_list_objc.txt
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@
# JSON input or output tests are skipped (in conformance_objc.m) as mobile
# platforms don't support JSON wire format to avoid code bloat.

Required.Editions_Proto2.ProtobufInput.UnknownOrdering.ProtobufOutput
Required.Editions_Proto3.ProtobufInput.UnknownOrdering.ProtobufOutput
Required.Proto2.ProtobufInput.UnknownOrdering.ProtobufOutput
Required.Proto3.ProtobufInput.UnknownOrdering.ProtobufOutput
Loading

0 comments on commit a6b3535

Please sign in to comment.