Skip to content

Commit

Permalink
Downgrade CMake to 3.29 to workaround Abseil issue.
Browse files Browse the repository at this point in the history
This was fixed in abseil/abseil-cpp@cd7f66c, but older versions of Abseil break in CMake 3.30, which github runners now use by default.

PiperOrigin-RevId: 651854867
  • Loading branch information
mkruskal-google authored and zhangskz committed Jul 17, 2024
1 parent 165cf12 commit bdb1f75
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/test_cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,12 @@ jobs:
arch: ${{ matrix.windows-arch || 'x64' }}
vsversion: ${{ matrix.vsversion }}

# Workaround for Abseil incompatibility with CMake 3.30 (b/352354235).
- name: Downgrade CMake
if: ${{ runner.os == 'Windows' }}
run: choco install cmake --version 3.29.6 --force
shell: bash

# Workaround for incompatibility between gcloud and windows-2019 runners.
- name: Install Python
if: ${{ matrix.python-version }}
Expand Down

0 comments on commit bdb1f75

Please sign in to comment.