Open sourcing reflection_visit_fieds.

Note that VisitFields() is an internal API and only meant for internal protobuf usages. PiperOrigin-RevId: 611586588
protocolbuffers · Feb 29, 2024 · cfc07df · cfc07df
1 parent 988194a
commit cfc07df
Show file tree

Hide file tree

Showing 6 changed files with 2,338 additions and 5 deletions.
diff --git a/src/google/protobuf/BUILD.bazel b/src/google/protobuf/BUILD.bazel
@@ -540,6 +540,8 @@ PROTOBUF_HEADERS = [
     "reflection_internal.h",
     "reflection_mode.h",
     "reflection_ops.h",
+    "reflection_visit_fields.h",
+    "reflection_visit_field_info.h",
     "service.h",
     "text_format.h",
     "unknown_field_set.h",

diff --git a/src/google/protobuf/generated_message_reflection.cc b/src/google/protobuf/generated_message_reflection.cc
@@ -357,10 +357,6 @@ bool Reflection::IsEagerlyVerifiedLazyField(
           schema_.IsEagerlyVerifiedLazyField(field));
 }
 
-bool Reflection::IsInlined(const FieldDescriptor* field) const {
-  return schema_.IsFieldInlined(field);
-}
-
 size_t Reflection::SpaceUsedLong(const Message& message) const {
   // object_size_ already includes the in-memory representation of each field
   // in the message, so we only need to account for additional memory used by

diff --git a/src/google/protobuf/message.h b/src/google/protobuf/message.h
@@ -1196,7 +1196,9 @@ class PROTOBUF_EXPORT Reflection final {
 
   internal::InternalMetadata* MutableInternalMetadata(Message* message) const;
 
-  inline bool IsInlined(const FieldDescriptor* field) const;
+  inline bool IsInlined(const FieldDescriptor* field) const {
+    return schema_.IsFieldInlined(field);
+  }
 
   bool HasBit(const Message& message, const FieldDescriptor* field) const;
   void SetBit(Message* message, const FieldDescriptor* field) const;