Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Bzlmod for managing external dependencies #14313

Open
meteorcloudy opened this issue Oct 6, 2023 · 6 comments
Open

Migrate to Bzlmod for managing external dependencies #14313

meteorcloudy opened this issue Oct 6, 2023 · 6 comments

Comments

@meteorcloudy
Copy link
Contributor

meteorcloudy commented Oct 6, 2023 •
edited
Loading

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check bazelbuild/bazel#18958

Related issue is #13618, but #13618 is more about providing a Bazel modules for users, this one is for tracking the migration of protobuf itself to use Bzlmod for managing both prod and dev external deps.
This was referenced Oct 6, 2023
Closed
Closed
@copybara-service copybara-service bot mentioned this issue Oct 12, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 12, 2023
@protobuf-github-bot @copybara-github
Disable Bzlmod explicitly in .bazelrc
224bfba 
This will help make sure [Bazel Downstream Pipeline](https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md) is green after enabling Bzlmod at Bazel@HEAD

See bazelbuild/bazel#18958 (comment)

Related #14313

Closes: #14314
PiperOrigin-RevId: 572848360
copybara-service bot pushed a commit that referenced this issue Oct 12, 2023
@protobuf-github-bot @copybara-github
Disable Bzlmod explicitly in .bazelrc
41fe430 
This will help make sure [Bazel Downstream Pipeline](https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md) is green after enabling Bzlmod at Bazel@HEAD

See bazelbuild/bazel#18958 (comment)

Related #14313

Closes: #14314
PiperOrigin-RevId: 572848360
copybara-service bot pushed a commit that referenced this issue Oct 12, 2023
@protobuf-github-bot @copybara-github
Disable Bzlmod explicitly in .bazelrc
3129868 
This will help make sure [Bazel Downstream Pipeline](https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md) is green after enabling Bzlmod at Bazel@HEAD

See bazelbuild/bazel#18958 (comment)

Related #14313

Closes: #14314
PiperOrigin-RevId: 572920528
@Wyverald Wyverald mentioned this issue Oct 31, 2023
Closed
copybara-service bot pushed a commit to tink-crypto/tink-cc that referenced this issue Nov 29, 2023
@morambro @copybara-github
Upgrade protobuf to 25.1
cc13b2d 
This requires:
 * Tentatively abandoning the use of Bzlmod. Protobuf doesn't support bzlmod yet [1] and the latest available protobuf in the Bazel Central Registry is 21.7 which provides incompatible JSON APIs [2]. Moving forward, we can re-introduce bzlmod when protobuf and Abseil officially support it.
 * Using the `--output_base=C:\O ` Bazel statup option on Windows [3] when building for Kokoro tests.

[1] protocolbuffers/protobuf#14313
[2] https://github.com/bazelbuild/bazel-central-registry/tree/7004deef786dc4152eedd3dfedf91b5b6b4590d4/modules/protobuf
[3] protocolbuffers/protobuf#12947

PiperOrigin-RevId: 586313367
Change-Id: Idc3f6d5a6e34b7da8fe51ea42ca354027a94a369
tholenst pushed a commit to tink-crypto/tink that referenced this issue Dec 4, 2023
@morambro @copybara-github
Upgrade protobuf to 25.1
dacb680 
This requires:
 * Tentatively abandoning the use of Bzlmod. Protobuf doesn't support bzlmod yet [1] and the latest available protobuf in the Bazel Central Registry is 21.7 which provides incompatible JSON APIs [2]. Moving forward, we can re-introduce bzlmod when protobuf and Abseil officially support it.
 * Using the `--output_base=C:\O ` Bazel statup option on Windows [3] when building for Kokoro tests.

[1] protocolbuffers/protobuf#14313
[2] https://github.com/bazelbuild/bazel-central-registry/tree/7004deef786dc4152eedd3dfedf91b5b6b4590d4/modules/protobuf
[3] protocolbuffers/protobuf#12947

PiperOrigin-RevId: 586313367
@SanjayVas SanjayVas mentioned this issue Dec 14, 2023
Open
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jan 24, 2024
@meteorcloudy
Copy link
Contributor Author

ping, to keep it active

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jan 25, 2024
This was referenced Feb 22, 2024
Closed
Closed
@mmorel-35 mmorel-35 mentioned this issue Mar 24, 2024
Closed
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Apr 25, 2024
@aaliddell
Copy link
Contributor

.

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Apr 26, 2024
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago. This issue will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jul 25, 2024
@ianb-pomelo
Copy link

.

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@meteorcloudy @aaliddell @ianb-pomelo and others