Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please bump rules_rust version to avoid failures when --incompatible_use_plus_in_repo_names is on #18546

Closed
tpasternak opened this issue Sep 30, 2024 · 5 comments · Fixed by #18638
Closed

Please bump rules_rust version to avoid failures when --incompatible_use_plus_in_repo_names is on #18546

tpasternak opened this issue Sep 30, 2024 · 5 comments · Fixed by #18638
Assignees
@JasonLunn @esrauchg
Labels
bazel rust

Comments

@tpasternak
Copy link

bazelbuild/rules_rust#2801
@tpasternak tpasternak added the untriaged auto added to all issues by default when created. label Sep 30, 2024
@JasonLunn
Copy link
Contributor

To clarify - what version of rules_rust addresses the issue discussed in bazelbuild/rules_rust#2801?

@JasonLunn JasonLunn added wait for user action and removed untriaged auto added to all issues by default when created. labels Oct 1, 2024
@tpasternak
Copy link
Author

So I tried the newest one and it was ok

@JasonLunn
Copy link
Contributor

Is that https://github.com/bazelbuild/rules_rust/releases/tag/0.51.0 @tpasternak ?

@tpasternak
Copy link
Author

yeah, it's fine

@tpasternak
Copy link
Author

it's easy to reproduce, just try bazel mod dump_repo_mapping --incompatible_use_plus_in_repo_names

copybara-service bot pushed a commit that referenced this issue Oct 7, 2024
@protobuf-github-bot @copybara-github
Bump rules_rust to 0.51 to fix #18546
033a449 
PiperOrigin-RevId: 683174880
@copybara-service copybara-service bot mentioned this issue Oct 7, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Oct 7, 2024
@protobuf-github-bot @copybara-github
Bump rules_rust to 0.51 to fix #18546
d2daefb 
PiperOrigin-RevId: 683174880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JasonLunn JasonLunn

@esrauchg esrauchg

Labels
bazel rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rules_rust to 0.51 to fix #18546 protocolbuffers/protobuf
3 participants
@JasonLunn @tpasternak @esrauchg