Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute well-known types protos in release packages. #289

Closed
xfxyjwf opened this issue Apr 17, 2015 · 3 comments
Closed

Distribute well-known types protos in release packages. #289

xfxyjwf opened this issue Apr 17, 2015 · 3 comments

Comments

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 17, 2015

Well-known types (e.g., any.proto) is part of protobuf library and will be referenced in users' .proto files. We need to distribute them along with protobuf runtime and protoc.

  1. The binary package for protoc will include well-known type protos (e.g., protoc-3.0.0-alpha-3-win32.zip).
  2. "make install" will install these .proto files along with proto header files. protoc will find the right import path for them without requiring users to specify it.
  3. The release package for each language may also have these protos included. For example, the .jar files we publish to Maven will include them.
  4. Plugins we provide/support (Maven plugin, Gradle plugin, IDE plugin, etc.) should better support them as well (e.g., be able to recognize an import of "google/protobuf/any.proto" without requiring users to put the source in a certain location).

Besides well-known types, google/protobuf/descriptor.proto will also in included.

@xfxyjwf xfxyjwf added this to the v3.0.0-alpha-3 milestone May 4, 2015
@xfxyjwf xfxyjwf self-assigned this May 4, 2015
@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented May 26, 2015

2 is done. 3 is done for Java. Moving this issue out of alpha-3 milestone and file individual issues instead.

@xfxyjwf xfxyjwf removed this from the v3.0.0-alpha-3 milestone May 26, 2015
kmontag added a commit to angellist/protip that referenced this issue Aug 4, 2015
@bufdev
Copy link

bufdev commented Nov 29, 2015

golang/protobuf#50

@xfxyjwf xfxyjwf added this to the v3.0.0 GA milestone Jan 20, 2016
@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented Jul 22, 2016

This should be working now for most languages. There are separate tracking issues for a specific language. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants