You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PROTOBUF_USE_DLLS and LIBPROTOBUF_EXPORTS are currently only defined/used with MSVC. Protobuf is used in chrome/chromium where we patch in this support downstream. However with the new addition of exporting template instantiations, this requires even more patching thus I thought we should just upstream the changes.
I created this issue to discuss the associated pull request #6535 since it was mentioned in the contributing doc to do so for complex changes (I am not sure if this applies here, but just in case). I would also suggest renaming PROTOBUF_USE_DLLS to something more reflective of the fact that it now also works on non-windows, however I did not do the change since this is something that is visible to third party users of the library rather than just internal macro definitions.
Note: the portion of this cl related to template exporting macros was not written by me but copied from the chromium repo with minor modifications. However it was written by a google engineer and is also covered by the same CLA as this project.
The text was updated successfully, but these errors were encountered:
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.
This issue is labeled inactive because the last activity was over 90 days ago.
We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.
This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.
PROTOBUF_USE_DLLS and LIBPROTOBUF_EXPORTS are currently only defined/used with MSVC. Protobuf is used in chrome/chromium where we patch in this support downstream. However with the new addition of exporting template instantiations, this requires even more patching thus I thought we should just upstream the changes.
I created this issue to discuss the associated pull request #6535 since it was mentioned in the contributing doc to do so for complex changes (I am not sure if this applies here, but just in case). I would also suggest renaming PROTOBUF_USE_DLLS to something more reflective of the fact that it now also works on non-windows, however I did not do the change since this is something that is visible to third party users of the library rather than just internal macro definitions.
Note: the portion of this cl related to template exporting macros was not written by me but copied from the chromium repo with minor modifications. However it was written by a google engineer and is also covered by the same CLA as this project.
The text was updated successfully, but these errors were encountered: