Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting LIBPROTOBUF_EXPORTS in clang #6536

Closed
m0hamed opened this issue Aug 19, 2019 · 2 comments
Closed

Supporting LIBPROTOBUF_EXPORTS in clang #6536

m0hamed opened this issue Aug 19, 2019 · 2 comments
Assignees
Labels
c++ inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@m0hamed
Copy link
Contributor

m0hamed commented Aug 19, 2019

PROTOBUF_USE_DLLS and LIBPROTOBUF_EXPORTS are currently only defined/used with MSVC. Protobuf is used in chrome/chromium where we patch in this support downstream. However with the new addition of exporting template instantiations, this requires even more patching thus I thought we should just upstream the changes.

I created this issue to discuss the associated pull request #6535 since it was mentioned in the contributing doc to do so for complex changes (I am not sure if this applies here, but just in case). I would also suggest renaming PROTOBUF_USE_DLLS to something more reflective of the fact that it now also works on non-windows, however I did not do the change since this is something that is visible to third party users of the library rather than just internal macro definitions.

Note: the portion of this cl related to template exporting macros was not written by me but copied from the chromium repo with minor modifications. However it was written by a google engineer and is also covered by the same CLA as this project.

Copy link

github-actions bot commented Apr 1, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Apr 1, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

No branches or pull requests

3 participants