Enable PROTOBUF_EXPORT/PROTOBUF_USE_DLL on clang/gcc #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0hamed
force-pushed
the
clang_export
branch
2 times, most recently
from
e14e064 to
064bb3d
Compare
|
@m0hamed Could you merge or rebase with master again to fix the merge conflicts? |
|
rebased onto master |
acozzette
reviewed
Aug 28, 2019
acozzette
reviewed
Aug 29, 2019
|
Why does this need to be so complicated? The explicit template instantiation macros contain a layer of indirection that is never used (we only ever explicitly instantiate templates with |
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBPROTOBUF_EXPORTS currently only works on MSVC, this patch should allow it to work on clang/gcc.