PHP: protobuf 3.19.1 causes several Deprecation notices

[caugner]

What version of protobuf and what language are you using?
Version: 3.19.1
Language: PHP

What operating system (Linux, Windows, ...) and version?

Docker 4.3.0 inside Ubuntu 20.04 LTS inside WSL2 on Windows 10

What runtime / compiler are you using (e.g., python version or gcc version)

# Dockerfile
FROM php:8.1-cli-alpine

RUN apk add --no-cache git && \
    curl -sSL -o /usr/local/bin/install-php-extensions https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions && \
    chmod uga+x /usr/local/bin/install-php-extensions && \
    sync && \
    install-php-extensions protobuf && \
    rm /usr/local/bin/install-php-extensions

What did you do?
Steps to reproduce the behavior:

1. Build the Dockerfile (docker build -t php-with-protobuf .)
2. Run the built Docker image (docker run --rm -it php-with-protobuf)

What did you expect to see

$ docker build -t php-with-protobuf .
$ docker run --rm -it php-with-protobuf
Interactive shell

php >

What did you see instead?

$ docker build -t php-with-protobuf .
$ docker run --rm -it php-with-protobuf
Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::offsetExists($index) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                 
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::offsetGet($index) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                      
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::offsetSet($index, $newval) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::offsetUnset($index) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                   
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                         
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                                                     
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedFieldIter::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                                            
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedFieldIter::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                                                   
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedFieldIter::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                                                    
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedFieldIter::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                                                 
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\RepeatedFieldIter::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                                               
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\MapField::offsetExists($index) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                      
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\MapField::offsetGet($index) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                           
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\MapField::offsetSet($index, $newval) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0     
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\MapField::offsetUnset($index) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                        
                                                                                                                                                                                                                                                                                                          
Deprecated: Return type of Google\Protobuf\Internal\MapField::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                              
                                                                                                                                                                                                                                                                            
Deprecated: Return type of Google\Protobuf\Internal\MapField::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                            
                                                                                                                                                                                                                                                                            
Deprecated: Return type of Google\Protobuf\Internal\MapFieldIter::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                   
                                                                                                                                                                                                                                                                            
Deprecated: Return type of Google\Protobuf\Internal\MapFieldIter::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                          
                                                                                                                                                                                                                                                                            
Deprecated: Return type of Google\Protobuf\Internal\MapFieldIter::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0                           

Deprecated: Return type of Google\Protobuf\Internal\MapFieldIter::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

Deprecated: Return type of Google\Protobuf\Internal\MapFieldIter::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
Interactive shell

php >

Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).

Anything else we should know about your project / environment

(No.)

[elharo]

3.9.1 is from a couple of years ago. Do you see this with the latest 3.19.1?

[caugner]

@elharo Sorry, my bad, this happens indeed with 3.19.1:

$ docker run --rm -it php-protobuf php -i | grep -A 2 ^protobuf$
protobuf

Version => 3.19.1

[mlocati]

This is still an issue with protobuf 3.19.2

[caugner]

FWIW There are two workarounds:

1. In your php.ini, set error_reporting = E_ALL & ~E_DEPRECATED
2. Prepend your CLI script with php -d 'error_reporting=24575'

I'm applying workaround 2 now, because the output of vendor/bin/php-cs-fixer fix --dry-run --format=gitlab > codeclimate.json cannot be parsed by GitLab due to the Deprecation notices (and redirecting stderr with 2> /dev/null did not help, because the deprecation notices are emitted via stdout).

[lanlin]

same issue on 3.19.3

[caugner]

I have linked some related PRs, of which #9359 seems to be the most promising PR with passing tests.

[haberman]

This should be fixed by #9370