Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake Ninja test #10314

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Conversation

mkruskal-google
Copy link
Member

@mkruskal-google mkruskal-google commented Jul 26, 2022

This PR also does some opportunistic cleanup of the CMake build. Notably:

  • ctest should be used for running tests, which runs everything registered with add_test
  • newer docker image is used to allow more flexibility in cmake configuration
  • .gitignore file updated to include CMake cruft

@mudream4869
Copy link

Not sure if I can ask question or not here...
I found that document of cmake changed in this PR:
From (v3.21.12)

This directory contains CMake files that can be used to build protobuf with MSVC on Windows. You can build the project from Command Prompt and using an Visual Studio IDE.

To

This directory contains CMake files that can be used to build protobuf.

Does it mean: in v3.21.12 version. The protobuf is still NOT ensure/mean cmake can be used in Linux, through it may be compiled and tested ok?

@mkruskal-google
Copy link
Member Author

No the opposite, we support cmake on all operating systems. That's why I removed some of the windows-specific language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of cmake and installation of cmake files on Linux
4 participants