Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto capitalize enums name in Ruby #10454

Merged
merged 21 commits into from
Sep 28, 2022
Merged

Auto capitalize enums name in Ruby #10454

Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ef80643
Auto capitalize enums name in Ruby
tisonkun Aug 24, 2022
44895f1
dup string for modification
tisonkun Aug 24, 2022
1314fb9
free name string
tisonkun Sep 4, 2022
3ac6b87
tolerate lowercase first letter for JRuby
tisonkun Sep 4, 2022
d30f0bb
add test cases
tisonkun Sep 4, 2022
b5da5e7
update the compiler
tisonkun Sep 9, 2022
8f604a7
use cpp style
tisonkun Sep 9, 2022
4515ed3
fix test
tisonkun Sep 9, 2022
a701223
add tests for lookup and resolve
tisonkun Sep 9, 2022
775a0e7
fix binary_json_conformance_suite
tisonkun Sep 13, 2022
86f13da
Revert "fix binary_json_conformance_suite"
tisonkun Sep 14, 2022
29bfb07
auto capitalize for json decode
tisonkun Sep 14, 2022
bc78de3
pass the correct argument
tisonkun Sep 14, 2022
f369bcb
update for JRuby
tisonkun Sep 14, 2022
4bb02e0
more jruby
tisonkun Sep 14, 2022
55a70a9
fix wording
tisonkun Sep 14, 2022
d93fa0b
add failure ignore
tisonkun Sep 15, 2022
114185c
Merge branch 'main' into patch-1
tisonkun Sep 28, 2022
4bc1091
revert CRuby Enum unrelated changes
tisonkun Sep 28, 2022
c02698a
revert JRuby Enum unrelated changes
tisonkun Sep 28, 2022
9d7fbf0
improve JRuby method
tisonkun Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ruby/ext/google/protobuf_c/message.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,13 +1263,17 @@ VALUE build_module_from_enumdesc(VALUE _enumdesc) {
int n = upb_EnumDef_ValueCount(e);
for (int i = 0; i < n; i++) {
const upb_EnumValueDef* ev = upb_EnumDef_Value(e, i);
const char* name = upb_EnumValueDef_Name(ev);
char* name = strdup(upb_EnumValueDef_Name(ev));
tisonkun marked this conversation as resolved.
Show resolved Hide resolved
int32_t value = upb_EnumValueDef_Number(ev);
if (name[0] < 'A' || name[0] > 'Z') {
rb_warn(
if (name[0] >= 'a' && name[0] <= 'z') {
name[0] -= 32; // auto capitalize
tisonkun marked this conversation as resolved.
Show resolved Hide resolved
} else {
rb_warn(
"Enum value '%s' does not start with an uppercase letter "
"as is required for Ruby constants.",
name);
}
}
rb_define_const(mod, name, INT2NUM(value));
}
Expand Down