Handle groups in C# JsonParser #16970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jskeet
approved these changes
May 29, 2024
|
@mkruskal-google This looks fine to me, but I don't know whether there's anything "special" I should be aware of in terms of JSON parsing for groups. PTAL. |
mkruskal-google
approved these changes
May 29, 2024
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
zhangskz
pushed a commit
that referenced
this pull request
Jun 1, 2024
mkruskal-google
added a commit
that referenced
this pull request
Jun 1, 2024
Handle groups in C# JsonParser (#16970)
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
Fixes protocolbuffers#16968 Closes protocolbuffers#16970 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16970 from CommonGuy:main b008e18 PiperOrigin-RevId: 638578696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16968