-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby] Warn if assigning a "UTF-8" string with invalid UTF-8. #17253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a warning now, but will be an error in the next version.
haberman
requested review from
acozzette and
ericsalo
and removed request for
a team
June 26, 2024 23:04
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 647111202
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 652963706
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 653236128
haberman
added a commit
that referenced
this pull request
Jul 17, 2024
This is a warning now, but will be an error in the next version. PiperOrigin-RevId: 653236128
haberman
added a commit
that referenced
this pull request
Jul 17, 2024
[Ruby] Warn if assigning a "UTF-8" string with invalid UTF-8. (#17253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a warning now, but will be an error in the next version.