Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compiler Condition to use inline assembly optimizations with ARM64 for Compatibility with MSVC #17671

Closed
wants to merge 4 commits into from
Closed

Add Compiler Condition to use inline assembly optimizations with ARM64 for Compatibility with MSVC #17671

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c656f8
Add! _MSC_VER condition
dsmith111 Jul 30, 2024
1b480d3
Fix formatting
dsmith111 Jul 30, 2024
7fe7949
Add msvc restriction to other failing optimization
dsmith111 Jul 30, 2024
765f8c8
Merge branch 'protocolbuffers:main' into smithdavi/msvc-compatibility…
dsmith111 Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/google/protobuf/parse_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ inline const char* VarintParseSlow(const char* p, uint32_t res, uint64_t* out) {
return tmp.first;
}

#ifdef __aarch64__
#if defined(__aarch64__) && !defined(_MSC_VER)
// Generally, speaking, the ARM-optimized Varint decode algorithm is to extract
// and concatenate all potentially valid data bits, compute the actual length
// of the Varint, and mask off the data bits which are not actually part of the
Expand Down Expand Up @@ -866,7 +866,7 @@ static const char* VarintParseSlowArm(const char* p, uint64_t* out,
// The caller must ensure that p points to at least 10 valid bytes.
template <typename T>
PROTOBUF_NODISCARD const char* VarintParse(const char* p, T* out) {
#if defined(__aarch64__) && defined(ABSL_IS_LITTLE_ENDIAN)
#if defined(__aarch64__) && defined(ABSL_IS_LITTLE_ENDIAN) && !defined(_MSC_VER)
// This optimization is not supported in big endian mode
uint64_t first8;
std::memcpy(&first8, p, sizeof(first8));
Expand Down
Loading