Windows - Fix handling of utf8 command line arguments #17854
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to:
Issues:
PRs:
The fix in #15519 has one line missing that breaks
Grpc.Tools
and doesn't actually fix the problem it proports to fix.This PR fixes this.
This fix needs to also be applied to the version of protobuf that is used by gRPC.
There are various scenarios that need to be tested on Windows:
A. Non-ascii command line arguments, e.g.
Failed output:
Success output:
.cs
file in theout
directoryB. Non-ascii arguments in a file containing the protoc arguments (no path to file) e.g.:
where
test.rsp
contains:Success output for both old and fixed code:
.cs
file in theout
directoryC. Non-ascii arguments in a file containing the protoc arguments (with non-ascii path to file).
(This is what
Grpc.Tools
uses.) e.g.Failed output:
Success output:
.cs
file in theout
directory