fix raw_ptr.cc on exotic architectures #18193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenzaquen
approved these changes
Sep 17, 2024
tonyliaoss
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
tonyliaoss
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
tonyliaoss
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Integration tests are failing due to version skew... I'm going to force-pull this one. |
|
I could rebase this change on top of any commit, if you provide it. However, I'd be able to rebase it in the middle of next week. |
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
I was working with an exotic architecture where ABSL_CACHELINE_SIZE of abseil was less than 64, so I got a compilation error about redefined symbols. I think the cc file should be adapted to the header file, so here is my change. Closes #18193 COPYBARA_INTEGRATE_REVIEW=#18193 from jagub2:raw_ptr_fix 4958e0f FUTURE_COPYBARA_INTEGRATE_REVIEW=#18193 from jagub2:raw_ptr_fix 4958e0f PiperOrigin-RevId: 676526640
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
I was working with an exotic architecture where ABSL_CACHELINE_SIZE of abseil was less than 64, so I got a compilation error about redefined symbols. I think the cc file should be adapted to the header file, so here is my change. Closes #18193 COPYBARA_INTEGRATE_REVIEW=#18193 from jagub2:raw_ptr_fix 4958e0f FUTURE_COPYBARA_INTEGRATE_REVIEW=#18193 from jagub2:raw_ptr_fix 4958e0f PiperOrigin-RevId: 676526640
|
Thanks for the offer Jakub! I think the force-pull went well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working with an exotic architecture where ABSL_CACHELINE_SIZE of abseil was less than 64, so I got a compilation error about redefined symbols. I think the cc file should be adapted to the header file, so here is my change.