Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --copt="-Werror" from .bazelrc #18392

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove --copt="-Werror" from .bazelrc #18392

merged 1 commit into from
Sep 18, 2024

Conversation

zhangskz
Copy link
Member

This appears to be causing a bunch of errors during our release process, but I don't think it's critical to have this flag in .bazelrc. We should still be able to get about the same test coverage since we also set -Werror in the bazelrc files in the ci/ directory.

PiperOrigin-RevId: 672673187

This appears to be causing a bunch of errors during our release process,
but I don't think it's critical to have this flag in `.bazelrc`. We
should still be able to get about the same test coverage since we also
set `-Werror` in the `bazelrc` files in the `ci/` directory.

PiperOrigin-RevId: 672673187
@mkruskal-google mkruskal-google merged commit 6481fec into 27.x Sep 18, 2024
29 checks passed
@mkruskal-google mkruskal-google deleted the cp-werror-fix branch September 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants